Fix Process resource leak in system metrics collection#17212
Open
PDGGK wants to merge 1 commit intoapache:masterfrom
Open
Fix Process resource leak in system metrics collection#17212PDGGK wants to merge 1 commit intoapache:masterfrom
PDGGK wants to merge 1 commit intoapache:masterfrom
Conversation
Add process.waitFor() and process.destroyForcibly() in finally block to prevent zombie processes when collecting system memory and network metrics via Runtime.exec(). Also handle InterruptedException properly by restoring the interrupt flag. Affected files: - SystemMetrics: memory info collection via 'free' command - LinuxNetMetricManager: socket count collection via 'ss' command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.waitFor()andprocess.destroyForcibly()infinallyblock to prevent zombie processes in periodic metrics collectionInterruptedExceptionproperly by restoring the interrupt flagSystemMetrics(memory) andLinuxNetMetricManager(socket count)Fixes #17211
Test plan